gszadovszky commented on code in PR #466: URL: https://github.com/apache/parquet-format/pull/466#discussion_r1843395569
########## LogicalTypes.md: ########## @@ -609,6 +609,17 @@ that is neither contained by a `LIST`- or `MAP`-annotated group nor annotated by `LIST` or `MAP` should be interpreted as a required list of required elements where the element type is the type of the field. +``` Review Comment: To address the oddity of the proper placing of the "1-level" list and such, maybe, we should create a separate doc for nested types. Then, we can reference this doc from both Readme and the logical types doc for LIST and MAP (and MAP_KEY_VALUE). In this new doc we could even mention "struct"... I agree with @wgtmac. Let's discuss the deprecation in a separate PR, probably starting with a discussion thread on the dev list. It would impact `parquet-java` and `parquet-rs` at least. Not sure, if we can use the 3-level list for protobuf. I'm not an expert. I'm not sure either why `parquet-rs` chosen to write "1-level" lists. The guys there should also be involved in this discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
