Fokko commented on code in PR #2951:
URL: https://github.com/apache/parquet-java/pull/2951#discussion_r1676940688
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestParquetFileWriter.java:
##########
@@ -286,6 +286,9 @@ public void testWriteRead() throws Exception {
w.endColumn();
w.endBlock();
w.end(new HashMap<String, String>());
+ // Although writer is already closed in previous end(),
+ // explicitly close it again to verify double close behavior.
+ w.close();
Review Comment:
Should we give a best practice in the test, and turn this into a
try-with-resource? The `ParquetFileWriter` is auto-closable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
