Fokko commented on code in PR #2949:
URL: https://github.com/apache/parquet-java/pull/2949#discussion_r1673743968
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java:
##########
@@ -230,11 +230,12 @@ protected Builder(InputFile file) {
if (file instanceof HadoopInputFile) {
HadoopInputFile hadoopFile = (HadoopInputFile) file;
this.conf = hadoopFile.getConfiguration();
- this.configuration = new HadoopParquetConfiguration(this.conf);
optionsBuilder = HadoopReadOptions.builder(this.conf,
hadoopFile.getPath());
} else {
+ this.conf = new Configuration();
optionsBuilder = ParquetReadOptions.builder(new
HadoopParquetConfiguration());
Review Comment:
The idea behind `HadoopParquetConfiguration` is to run without Hadoop. With
this line we initialize a Hadoop configuration while it is not a Hadoop file.
What do you think of:
```suggestion
this.configuration = new HadoopParquetConfiguration();
optionsBuilder = ParquetReadOptions.builder(this.configuration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
