kerneltime commented on PR #7396: URL: https://github.com/apache/ozone/pull/7396#issuecomment-2484214305
This PR looks fine. I wondered if we should have an enum in code for all the container failures and reuse them in test vs. test defining their enums. We can then assert if a new failure mode is added, but no relevant test was added. This can be a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
