swamirishi commented on PR #7179: URL: https://github.com/apache/ozone/pull/7179#issuecomment-2342483516
> 1. other tha > Thanks @swamirishi for working on this. > > 1. Left a few comments and questions other than the same comments from [HDDS-11244. Draft PR to address multiple issues in garbage collection. Will split it into multiple PRs #7097](https://github.com/apache/ozone/pull/7097) about skipping cache for transactionInfoTable read and converting ByteString to byte[] and vice-versa in SnapshotInfo. > 2. I don't see the usage of `OmSnapshotManager#areSnapshotChangesFlushedToDB`. I believe it will be a follow-up PR. One question I've around it is if `lastTransactionInfo` is not persisted in DB how it will work if OM restarts. Are we relying that it will be eventually flushed to DB by another thread? If the OM restarts, the transaction would be replayed. ValidateAndUpdateCache is always called on applyTransaction phase of ratis. The OM only starts up only after all the transactions have been replayed and applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
