kerneltime commented on code in PR #7167:
URL: https://github.com/apache/ozone/pull/7167#discussion_r1750568933
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java:
##########
@@ -128,6 +129,14 @@ public class DBScanner implements Callable<Void>,
SubcommandWithParent {
"eg.) \"name,acls.type\" for showing name and type under acls.")
private String fieldsFilter;
+ @CommandLine.Option(names = {"--filter"},
+ description = "Comma-separated list of \"<field>:<operator>:<value>\"
where " +
+ "<field> is any valid field of the record, " +
+ "<operator> is (EQUALS,MAX or MIN) and " +
+ "<value> is the value of the field. " +
+ "eg.) \"dataSize:equals:1000\" for showing records having the value
1000 for dataSize")
Review Comment:
How does multiple matches work? If we have multiple fields called `size` or
`version` or `name`, how will the visual representation tell me which field is
being filtered? How does `MIN` and `MAX` work with strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
