sodonnel commented on code in PR #7140:
URL: https://github.com/apache/ozone/pull/7140#discussion_r1747287826
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/AbstractReplicationTask.java:
##########
@@ -70,6 +70,14 @@ protected AbstractReplicationTask(long containerID,
this.term = term;
queued = Instant.now(clock);
}
+
+ protected String getMetricName() {
Review Comment:
I would suggest making these abstract methods, which would force any
sub-class to implement them or get a compile error. This would reduce the
chances of a new type of task of missing these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
