fapifta commented on PR #7135: URL: https://github.com/apache/ozone/pull/7135#issuecomment-2323494438
Thank you @adoroszlai for the review, yes, you are right, if we are called from outside that is where the problem arise! > For this reflection to work, Ozone already sets the required --add-opens here: I would like to note here that in case we use the add-opens for nio just for this reflective access, then after this patch we won't need that I believe, as this way the Java8 implementation part does what it can do as there are no module restrictions in Java8, while in Java9 and above, we use the update method instead, which is accessible. @kerneltime thank you for your review also, I think @adoroszlai already addressed your concern. @slfan1989 thank you for the review for you too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
