adoroszlai commented on code in PR #6924:
URL: https://github.com/apache/ozone/pull/6924#discussion_r1675970759
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -426,6 +426,11 @@ public void onMessage(
DatanodeDetails details = deleteBlockStatus.getDatanodeDetails();
UUID dnId = details.getUuid();
+ UUID dnIdLocal = UUID.fromString(dnId.toString());
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("remoteId = {}, localDnId = {}, remoteDnId == localDnId[{}]",
+ dnId, dnIdLocal, (dnId == dnIdLocal));
Review Comment:
```
2024-07-12 08:35:37,032
[scm3-EventQueue-DeleteBlockStatusForDeletedBlockLogImpl] DEBUG
org.apache.hadoop.hdds.scm.block.DeletedBlockLogImpl: remoteDnId =
888a550f-c59c-4dde-ba3e-3dcf8f9593e0, localDnId =
888a550f-c59c-4dde-ba3e-3dcf8f9593e0, remoteDnId == localDnId[false]
...
```
@slfan1989 These sample log lines do not indicate any problem.
`UUID.fromString` returns a new instance, so `==` will always be `false`.
Please log result of `equals()` instead of `==`.
> we applied this PR in the production environment. Currently, SCM deletion
can proceed normally
Is it possible that it can proceed simply because SCM was restarted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
