smitajoshi12 commented on code in PR #6535:
URL: https://github.com/apache/ozone/pull/6535#discussion_r1618721275
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/diskUsage/diskUsage.tsx:
##########
@@ -144,20 +145,19 @@ export class DiskUsage extends
React.Component<Record<string, object>, IDUState>
const dataSize = duResponse.size;
let subpaths: IDUSubpath[] = duResponse.subPaths;
- subpaths.sort((a, b) => (a.size < b.size) ? 1 : -1);
-
- // Only show top n blocks with the most DU,
- // other blocks are merged as a single block
- if (subpaths.length > limit) {
+ // This logic is for other objects for Max Limit 30 we are calculating
+ // Other Object Size = Total Size - Sum of all subpaths Size
+ if (subpaths.length >= limit || (subpaths.length > 0 && limit ===
MAX_DISPLAY_LIMIT)) {
Review Comment:
@dombizita Other Objects are depending on Total size and sum of all
subpaths Size.
Example 1
Limit=10 and subpaths.length=10
Total Size =100KB Sum of all 10 nodes size=90KB then we need to show
remaining 10 in other objects to cover this test case checking condition >=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
