duongkame commented on code in PR #6690:
URL: https://github.com/apache/ozone/pull/6690#discussion_r1612104239
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChunkBufferImplWithByteBuffer.java:
##########
@@ -163,4 +175,12 @@ public String toString() {
return getClass().getSimpleName() + ":limit=" + buffer.limit()
+ "@" + Integer.toHexString(hashCode());
}
+
+ @Override
+ protected void finalize() throws Throwable {
Review Comment:
Please see LeakDetector (HDDS-9528) @ChenSammi .
Yet, relying on GC activity to perform resource closure may not be a good
idea, because we have no control over when GC would cleanup unreachable
objects. Usually people only reply on finalizer/WeakReference to detect leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
