symious commented on code in PR #6558:
URL: https://github.com/apache/ozone/pull/6558#discussion_r1587342928
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManager.java:
##########
@@ -119,6 +122,24 @@ default void
registerSendCommandNotify(SCMCommandProto.Type type,
List<DatanodeDetails> getNodes(
NodeOperationalState opState, NodeState health);
+ /**
+ * Gets all Live Datanodes that is currently communicating with SCM.
+ * The result is always not null.
+ * @param opStates - The operational states of the node
+ * @param health - The health of the node
+ * @return List of Datanodes that are Heartbeating SCM.
+ */
+ default List<DatanodeDetails> getNodes(
Review Comment:
@sodonnel IMHO, the current changes should be a long-term solution, the
change of maxRetries is currently being used in our cluster, but not a good way
when the cluster is getting bigger.
For the `getNodes` part, we should improve the performance for the general
usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
