fapifta commented on PR #6580: URL: https://github.com/apache/ozone/pull/6580#issuecomment-2079273955
Thank you @adoroszlai for the review, let's see if @szetszwo is also ok with this patch, or at least give him a chance to react for some time. So what I did, I just reverted the unrelated formatting change, and the change in compactionIfNeeded, so that it is using the old way with ISO-8859-1 conversion. In the meantime I have added [HDDS-10762](https://issues.apache.org/jira/browse/HDDS-10762) as I have some performance concerns, also I kind of have technical concerns around this, as in an other place the same smallestKey and largetKey result is converted using UTF-8 conversion, and this was the original state also, so we have two code parts that handles this same data differently... But it is out of my knowledge area, and I can not spend more time on to understand this as of now. With that this patch should preserve the old behaviour, using the same formats and charsets for the conversion, but via the same method call instead of using different utilities at different places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
