adoroszlai commented on code in PR #6508:
URL: https://github.com/apache/ozone/pull/6508#discussion_r1569070957
##########
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/fs/TestCachingSpaceUsageSource.java:
##########
@@ -142,6 +142,21 @@ public void savesValueOnShutdown() {
verify(executor).shutdown();
}
+ @Test
+ public void testDecrementDoesNotGoNegative() {
+ SpaceUsageCheckParams params = paramsBuilder(new AtomicLong(50))
+ .withRefresh(Duration.ZERO)
+ .build();
+ CachingSpaceUsageSource subject = new CachingSpaceUsageSource(params);
+ AtomicLong cachedValue = new AtomicLong(50);
Review Comment:
```
H D DLS: Dead store to cachedValue in
org.apache.hadoop.hdds.fs.TestCachingSpaceUsageSource.testDecrementDoesNotGoNegative()
At TestCachingSpaceUsageSource.java:[line 151]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
