tanvipenumudy commented on code in PR #6434:
URL: https://github.com/apache/ozone/pull/6434#discussion_r1537338148
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1155,11 +1157,15 @@ public void setScmTopologyClient(
}
public NetworkTopology getClusterMap() {
- InnerNode currentTree = scmTopologyClient.getClusterTree();
- return new NetworkTopologyImpl(configuration.get(
- ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE,
- ScmConfigKeys.OZONE_SCM_NETWORK_TOPOLOGY_SCHEMA_FILE_DEFAULT),
- currentTree);
+ InnerNode fetchedTree = scmTopologyClient.getClusterTree();
+ if (!clusterTree.equals(fetchedTree)) {
Review Comment:
This is a good idea, I will refactor these changes to `ScmTopologyClient`
for utilizing the existing comparison logic avoiding the duplicate comparison +
maintenance of class variables, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
