will-sh opened a new pull request, #6347: URL: https://github.com/apache/ozone/pull/6347
## What changes were proposed in this pull request? HDDS-10090.Clean up TestStorageContainerManager Please describe your PR in detail: Several goals in this jira have been achieved: * Disabled test cases related to non-HA to HA change. This used to be not supported scenario, but was recently implemented in [HDDS-9897](https://issues.apache.org/jira/browse/HDDS-9897). Since that task also added a new test case, testSCMReinitializationWithHAEnabled and testSCMReinitializationWithHAUpgrade can be removed now. * Thread.currentThread().sleep() can be replaced with Thread.sleep(). * Replace usage of GenericTestUtils.getTempPath with @TempDir. The below items are not fixed yet, I will post some uncertain parts to the PR discussion. * Test cases can now use MiniOzoneCluster wrapped in try-with-resources blocks to ensure the cluster is shut down even if waitForClusterToBeReady() and other operations fail. * Convert try-catch blocks to assertThrows() where applicable (where exception is expected and try block calls fail(). ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-10090 ## How was this patch tested? The below tests are passed - manual tests: `mvn test -Dtest=TestStorageContainerManager` - CI workflow run on the fork git repo (https://github.com/will-sh/ozone/actions/runs/8191346419) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
