adoroszlai commented on code in PR #6196:
URL: https://github.com/apache/ozone/pull/6196#discussion_r1484129190
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestSstFilteringService.java:
##########
@@ -180,13 +183,14 @@ public void testIrrelevantSstFileDeletion()
assertThat(nonLevel0FilesCountAfterCompact).isGreaterThan(0);
String bucketName2 = "buck2";
- createVolumeAndBucket(volumeName, bucketName2);
+ addBucketToVolume(volumeName, bucketName2);
createKeys(volumeName, bucketName2, keyCount);
activeDbStore.getDb().flush(OmMetadataManagerImpl.KEY_TABLE);
List<LiveFileMetaData> allFiles = activeDbStore.getDb().getSstFileList();
String snapshotName1 = "snapshot1";
writeClient.createSnapshot(volumeName, bucketName2, snapshotName1);
+ countTotalSnapshots++;
Review Comment:
I suggest extracting these two statements into a method (and using it for
other similar two-liners) to:
- ensure count is incremented for each snapshot
- reduce duplication
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestSstFilteringService.java:
##########
@@ -71,24 +75,21 @@
/**
* Test SST Filtering Service.
*/
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@TestMethodOrder(OrderAnnotation.class)
public class TestSstFilteringService {
- public static final String SST_FILE_EXTENSION = ".sst";
- @TempDir
- private File folder;
+ private static final String SST_FILE_EXTENSION = ".sst";;
Review Comment:
nit:
```suggestion
private static final String SST_FILE_EXTENSION = ".sst";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
