adoroszlai commented on PR #5954: URL: https://github.com/apache/ozone/pull/5954#issuecomment-1884514555
> Do we still need to retain the 'ozone.scm.handler.count.key' configuration in ozone-default.xml? `<property> <name>ozone.scm.handler.count.key</name> <value>100</value> </property>` Keeping it is not strictly necessary for using it as a fallback. However, `TestOzoneConfigurationFields` checks whether the config keys defined as Java constant and the ones defined in `ozone-default.xml` match. If we simply remove the property from `ozone-default.xml` and keep the constant, the test will fail. Possible solutions: 1. Keep the property, but edit its description, to refer admins to the more specific properties they can fine-tune. 2. Remove the property, and add the constant as an exception in `TestOzoneConfigurationFields#addPropertiesNotInXml`. 3. Remove the property, and move the constant to some other class that is not verified by `TestOzoneConfigurationFields`. I would choose (1) or (2), but let's wait for confirmation from @szetszwo and @duongkame. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
