[ 
https://issues.apache.org/jira/browse/HDDS-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796041#comment-17796041
 ] 

Attila Doroszlai commented on HDDS-9905:
----------------------------------------

bq. There seem to be many modules here that use "javax.annotation.Nullable".

{code}
javax.annotation.Nonnull: 102
javax.annotation.Nullable: 44
org.jetbrains.annotations.NotNull: 58
org.jetbrains.annotations.Nullable: 2
{code}

bq. Do all of these need to be replaced?

I would like to replace the {{org.jetbrains}} annotations and keep the 
{{javax.annotation}} ones.

bq. Or is it for a specific module?

No, we can make the change for all modules in one step.

> Standardize nullability annotations
> -----------------------------------
>
>                 Key: HDDS-9905
>                 URL: https://issues.apache.org/jira/browse/HDDS-9905
>             Project: Apache Ozone
>          Issue Type: Task
>            Reporter: Attila Doroszlai
>            Priority: Minor
>         Attachments: screenshot-1.png, screenshot-2.png
>
>
> Let's standardize annotations related to null values.  I propose preferring:
> {code}
> javax.annotation.Nonnull
> javax.annotation.Nullable
> {code}
> instead of:
> {code}
> org.jetbrains.annotations.NotNull
> org.jetbrains.annotations.Nullable
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to