Attila Doroszlai created HDDS-9806:
--------------------------------------
Summary: Refactor TestBlockOutputStream
Key: HDDS-9806
URL: https://issues.apache.org/jira/browse/HDDS-9806
Project: Apache Ozone
Issue Type: Improvement
Components: test
Reporter: Attila Doroszlai
Assignee: Attila Doroszlai
* {{TestBlockOutputStream}} is duplicated as {{TestBlockOutputStreamFlushDelay}}
* {{TestBlockOutputStreamWithFailures}} is duplicated as
{{TestBlockOutputStreamWithFailuresFlushDelay}}
The main difference between the duplicates is that the ones without
{{FlushDelay}} set {{OzoneClientConfig.setStreamBufferFlushDelay(false)}},
while the ones with {{FlushDelay}} rely on the default value for this property
being {{true}}.
The goal of this task is to reduce code duplication.
Furthermore, {{streamBufferFlushDelay}} is a client-side config, so we can
completely merge {{TestBlockOutputStream}} and
{{TestBlockOutputStreamFlushDelay}} by:
* making test cases parameterized
* creating a new client for each test case
{code}
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStreamFlushDelay.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStreamWithFailures.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStreamWithFailuresFlushDelay.java
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
