smengcl commented on code in PR #11944:
URL: https://github.com/apache/ozone/pull/11944#discussion_r4479078897
##########
.github/workflows/post-commit.yml:
##########
@@ -16,10 +16,11 @@ name: build-branch
on:
pull_request:
types: [opened, ready_for_review, synchronize]
- branches-ignore:
+ # unignore `master` until Fork CI Status workflow is refined
+ # branches-ignore:
# ignore pull requests targeted at these branches,
# the list must match base-branches in fork-ci-status.yaml
- - master
+ # - master
push:
branches-ignore:
Review Comment:
Since `pull_request` runs for `master` again, should we also bring back
`'dependabot**'` here? #11871 dropped it from this list because dependabot PRs
no longer had a `pull_request` run. Without it, each dependabot PR to `master`
gets two full CI runs: one for the push to its branch in apache/ozone
(concurrency group `ci-<sha>`) and one for the PR (`ci-<PR number>`), so
neither cancels the other.
```yaml
branches-ignore:
# only master, builds on schedule
- master
- 'dependabot**'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
