adoroszlai opened a new pull request, #11886:
URL: https://github.com/apache/ozone/pull/11886

   ## What changes were proposed in this pull request?
   
   Cut the `ozone-integration-test-(freon|recon|s3|tools) -> 
ozone-integration-test` dependency.
   
   1. Move test helper classes used in these modules to the new 
`ozone-integration-test-utils`.  Keep them in their diverse packages for now, 
to reduce change in imports.
   2. Move helpers which do not use `MiniOzoneCluster` from 
`TestOzoneContainer` to `ContainerTestUtils`.
   3. Move `ClusterForTesting` to `mini-ozone-cluster`, pushing down the 
JUnit-specific annotations.  This keeps `mini-ozone-cluster` agnostic of the 
test framework (for use in downstream projects).
   4. Move `NonHATests.TestCase` up to `ClusterForTesting`, and create 
intermediate class `HACluster` between `HATests` and `ClusterForTesting` for 
the same purpose.
   
   Also fix two bugs introduced recently, not worth separate patches:
   - `integration.sh` did not match `-pl :<module>` correctly due to quotes, so 
`testset` was never added to arguments
   - `DebugTests` is abstract; for running it, we need a concrete subclass 
(added `TestOzoneDebug`)
   
   https://issues.apache.org/jira/browse/HDDS-17637
   
   ## How was this patch tested?
   
   CI for the build changes:
   https://github.com/adoroszlai/ozone/actions/runs/41277635462
   
   `DebugTests` issue: verified that it was 
[run](https://github.com/adoroszlai/ozone/actions/runs/41277635462/job/124782548200#step:17:133)
 in CI.
   
   ```
   [INFO] Running org.apache.ozone.test.TestOzoneDebug
   [INFO] Running org.apache.ozone.test.DebugTests$OzoneDebugReplicasVerify
   [INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.058 
s -- in org.apache.ozone.test.DebugTests$OzoneDebugReplicasVerify
   [INFO] Running org.apache.ozone.test.DebugTests$OzoneDebugShell
   [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.29 s -- in org.apache.ozone.test.DebugTests$OzoneDebugShell
   [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.82 
s -- in org.apache.ozone.test.TestOzoneDebug
   ```
   
   `integration.sh` issue:
   
   ```
   $ hadoop-ozone/dev-support/checks/integration.sh -pl :ozone-manager
   ...
   ++ mvn -B ... -Dscan.value.testset=ozone-manager -pl :ozone-manager clean 
test
   ...
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to