chihsuan commented on code in PR #11479:
URL: https://github.com/apache/ozone/pull/11479#discussion_r4426262733
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -3162,7 +3172,7 @@ public Map<String, String> getObjectTagging(
throw new IOException("OzoneManager does not support S3 object tagging
API");
}
- boolean assumeS3Context = volumeName == null && resolveS3VolumeOnOm;
+ boolean assumeS3Context = volumeName == null;
Review Comment:
Thanks for raising this! @chungen0126 From what I can see, only S3G passes
a `null` volume, which is why I thought the gate was intentional. But since OM
already resolves the default S3 volume for clients without an S3 identity,
dropping it sounds good to me.
I noticed the OM version check is also dropped here, though. I think we
should keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
