smengcl commented on code in PR #11779:
URL: https://github.com/apache/ozone/pull/11779#discussion_r4405443599
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyRenameResponseWithFSO.java:
##########
@@ -92,7 +94,10 @@ public void addToDBBatch(OMMetadataManager omMetadataManager,
getRenameKeyInfo().getObjectID());
String renamedKey = omMetadataManager.getSnapshotRenamedTable()
.get(renameDbKey);
- if (isSnapshotBucket && renamedKey == null) {
+ Table<String, ? extends WithObjectID> fromTable = isRenameDirectory
+ ? omMetadataManager.getDirectoryTable() :
omMetadataManager.getKeyTable(getBucketLayout());
+ if (isSnapshotBucket && renamedKey == null
Review Comment:
Thanks, moved the whole snapshotRenamedTable block (snapshot bucket check,
existing entry check, committed source check, put) into one helper,
`OMKeyRenameResponse.addToSnapshotRenamedTable`, which all three responses call
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
