adwetojha commented on code in PR #11752:
URL: https://github.com/apache/ozone/pull/11752#discussion_r4388505557
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableRatisContainerProvider.java:
##########
@@ -136,9 +143,12 @@ public ContainerInfo getContainer(final long size,
LOG.error(
"Unable to allocate a block for the size: {}, repConfig: {}",
size, repConfig);
- throw new IOException(
- "Unable to allocate a container to the block of size: " + size
- + ", replicationConfig: " + repConfig + ". " + failureReason);
+ String message = "Unable to allocate a container to the block of size: " +
size
+ + ", replicationConfig: " + repConfig + ". " + failureReason;
+ if (missingPipeline != null) {
Review Comment:
I investigated this case. The final container lookup can return null both
when the waited pipeline closes and when an OPEN pipeline has no suitable
container.
I avoided classifying both as retryable because that could cause unnecessary
retries for capacity-related failures.
Would you be okay with handling the opens-then-closes race in a separate
JIRA with a deterministic regression test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
