rjgoyln commented on code in PR #11778:
URL: https://github.com/apache/ozone/pull/11778#discussion_r4381362901
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java:
##########
@@ -255,6 +258,13 @@ public SCMRegisteredResponseProto register(
pipelineReportsProto));
}
try {
+ if (registeredCommand.getError() ==
SCMRegisteredResponseProto.ErrorCode.errorNodeNotPermitted && !leaderReady) {
Review Comment:
One small, non-blocking concern:
`shouldFenceDatanode` also rejects DNs running newer software than the SCM,
which a follower cannot resolve by catching up on the Ratis log.
With the current change, DNs could keep running as long as the leader
accepts them, only to be rejected and shut down if the older follower later
becomes leader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
