echonesis commented on code in PR #11781:
URL: https://github.com/apache/ozone/pull/11781#discussion_r4386593314
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/tenant/TestOMTenantCreateRequest.java:
##########
@@ -133,6 +138,38 @@ public void testValidateAndUpdateCache() throws
IOException {
omMetadataManager.getVolumeKey(tenantId)));
}
+ @ParameterizedTest
+ @ValueSource(strings = {"username", "[email protected]"})
+ public void testValidateAndUpdateCacheAddsVolumeToOwnerVolumeList(String
userName) throws Exception {
Review Comment:
nit: Could we also add a regression test for the owner's volume-count limit?
With one existing volume, getMaxUserVolumeCount() returning 1L, and a full
Kerberos principal in UserInfo, tenant creation should return
USER_TOO_MANY_VOLUMES and preserve the existing volume list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
