ChenSammi commented on code in PR #11454:
URL: https://github.com/apache/ozone/pull/11454#discussion_r4384822085
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientManager.java:
##########
@@ -91,6 +98,10 @@ public XceiverClientManager(ConfigurationSource conf,
Objects.requireNonNull(conf, "conf == null");
long staleThresholdMs = clientConf.getStaleThreshold(MILLISECONDS);
+ // at most one thread, which exits when idle
+ this.closeExecutor = new ThreadPoolExecutor(0, 1, 60, TimeUnit.SECONDS,
Review Comment:
Thanks @smengcl , it's a good improvement.
Can we make this LinkedBlockingQueue with no limit? Since it has the chance
to beyond the clientConf.getMaxSize(), and I see you have addressed in the
closeAsync, while if the rejection happens, it will fall back to synchronize
close.
BTW, this LinkedBlockingQueue very unlikely can grow unlimited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
