Russole commented on code in PR #11773:
URL: https://github.com/apache/ozone/pull/11773#discussion_r4379237308
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerScannerConfiguration.java:
##########
@@ -42,9 +42,9 @@ public class ContainerScannerConfiguration {
public static final String HDDS_CONTAINER_SCRUB_ENABLED =
"hdds.container.scrub.enabled";
public static final String HDDS_CONTAINER_SCRUB_DEV_DATA_ENABLED =
- "hdds.container.scrub.dev.data.enabled";
+ "hdds.container.scrub.dev.data.scan.enabled";
public static final String HDDS_CONTAINER_SCRUB_DEV_METADATA_ENABLED =
- "hdds.container.scrub.dev.metadata.enabled";
+ "hdds.container.scrub.dev.metadata.scan.enabled";
Review Comment:
Could making this key effective leave the data and on-demand scanners
running during shutdown when metadata scanning is disabled? Should
`stopContainerScrub()` shut down each scanner independently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
