andyhuangdev opened a new pull request, #11756: URL: https://github.com/apache/ozone/pull/11756
## What changes were proposed in this pull request? Remove the unregistration of shared XceiverClientMetrics from XceiverClientManager.close(). The metrics instance is static and shared by all managers in the JVM. Closing one manager currently unregisters the metrics source for all others. Subsequent managers reuse the same instance without re-registering it, leaving metrics unavailable. This change keeps the shared metrics registered for the lifetime of the JVM while preserving cleanup of each manager's cache metrics. ## What is the link to the Apache JIRA [HDDS-17434](https://issues.apache.org/jira/browse/HDDS-17434) ## How was this patch tested? Added a regression test verifying that metrics remain registered and collect updated counters after one manager closes, and remain available when a new manager is created after all previous managers close. The test failed before the fix and passed afterward. All 5 tests across TestXceiverClientManagerMetrics, TestContainerClientMetrics, and TestXceiverClientManagerCloseContention passed. Checkstyle passed. RAT reported 60 existing license issues under dev-support/ci/bats-*; the new test file passed its license check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
