sodonnel commented on code in PR #11692:
URL: https://github.com/apache/ozone/pull/11692#discussion_r4359099963
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManager.java:
##########
@@ -408,6 +408,16 @@ void processNodeReport(DatanodeDetails datanodeDetails,
*/
void processVersionReport(DatanodeDetails datanodeDetails,
DatanodeVersionProto versionReport);
+ /**
+ * Returns true if the datanode should be blocked from joining the cluster
due to a version
+ * incompatibility with this SCM. See {@code
SCMNodeManager.shouldFenceDatanode} for the full
+ * set of conditions. Returns false by default for implementations that do
not enforce versioning.
Review Comment:
I have added this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
