cchung100m commented on code in PR #11550:
URL: https://github.com/apache/ozone/pull/11550#discussion_r4346983598


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/MergeJoinSnapDiffWriter.java:
##########
@@ -128,6 +128,10 @@ private static void classifyMergeJoin(SnapDiffJobStore 
store, boolean isFso) thr
     store.flushWrites();
   }
 
+  private static Map.Entry<Long, byte[]> 
nextOrNull(SnapDiffJobStore.ListIterator iterator) {
+    return iterator.hasNext() ? iterator.next() : null;
+  }

Review Comment:
   Good point, thanks. Moved it into `SnapDiffJobStore.ListIterator` as a 
package-private `nextOrNull()` and updated the call sites in 
`MergeJoinSnapDiffWriter`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to