jojochuang commented on code in PR #11645: URL: https://github.com/apache/ozone/pull/11645#discussion_r4341358200
########## hadoop-ozone/dist/src/main/smoketest/upgrade/snapshot.robot: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Documentation Create a snapshot, read earlier snapshots and diff against the previous one +Library OperatingSystem +Library String +Library BuiltIn +Resource ../commonlib.robot +Suite Setup Kinit test user testuser testuser.keytab +Test Timeout 5 minutes + +*** Variables *** +${PREFIX} +${SNAPSHOT} +${FROM_SNAPSHOT} +${EARLIER_SNAPSHOTS} + +*** Keywords *** +Snapshot diff should be done + ${output} = Execute ozone sh snapshot diff --get-report --json /${PREFIX}-volume/${PREFIX}-bucket ${FROM_SNAPSHOT} ${SNAPSHOT} | jq -r '.jobStatus' Review Comment: Optional: Preserve compatibility with manually enabled older upgrade cases Correction to my original P2 assessment: `compose/upgrade/test.sh` currently enables only the non-rolling upgrade from **2.2.1**. The 2.1.1, 1.4.1, and 1.4.0 entries are commented out. I verified that the 2.2.1 CLI supports both `--get-report` and `--json`, so this command is valid for the currently enabled CI run. The snapshot helper's guard permits versions from 1.4.0 onward, but that does not mean those versions are actually run. The suggested legacy fallback matters only if the older release-matrix cases are manually enabled. Please treat this as optional older-version compatibility work, not a P2 defect in the configured upgrade test. Generated-by: Codex (GPT-6) ########## hadoop-ozone/dist/src/main/smoketest/upgrade/snapshot.robot: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Documentation Create a snapshot, read earlier snapshots and diff against the previous one +Library OperatingSystem +Library String +Library BuiltIn +Resource ../commonlib.robot +Suite Setup Kinit test user testuser testuser.keytab +Test Timeout 5 minutes + +*** Variables *** +${PREFIX} +${SNAPSHOT} +${FROM_SNAPSHOT} +${EARLIER_SNAPSHOTS} + +*** Keywords *** +Snapshot diff should be done + ${output} = Execute ozone sh snapshot diff --get-report --json /${PREFIX}-volume/${PREFIX}-bucket ${FROM_SNAPSHOT} ${SNAPSHOT} | jq -r '.jobStatus' Review Comment: @smengcl Correction to the scope of my review and suggested patch: the enabled matrix in `compose/upgrade/test.sh` runs from **2.2.1**, whose CLI supports both options. I incorrectly treated the snapshot helper's >=1.4.0 eligibility guard as the active test matrix. The older entries are commented out. I have corrected the original review comment and withdrawn the P2 characterization. The fork commit is optional compatibility support for manually enabling older upgrade cases; it is not necessary to fix the currently enabled 2.2.1 run. Generated-by: Codex (GPT-6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
