SaketaChalamchala commented on PR #11009: URL: https://github.com/apache/ozone/pull/11009#issuecomment-6323561275
Thanks for the patch @smengcl. This change lgtm. Just a small follow up, could you add a tests for: 1. similar to KDS `testSnapshotDbHandleClosedBeforeSubmit` to assert that `SNAPSHOT_DB` locks are released before submitting purge requests? 2. A test where a deletion task worker throws (maybe in reclaimable filter) and assert that `processDeletedDirsForStore` does not hang and `SNAPSHOT_DB` locks are released Also, PTAL at the CI failures and the merge conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
