chungen0126 commented on code in PR #11479:
URL: https://github.com/apache/ozone/pull/11479#discussion_r4332247684
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -499,6 +499,7 @@ message OMResponse {
optional StartFinalizeUpgradeResponse startFinalizeUpgradeResponse =
159;
optional QueryUpgradeStatusResponse queryUpgradeStatusResponse =
160;
optional CompleteFinalizeUpgradeResponse completeFinalizeUpgradeResponse =
161;
+ optional string userPrincipal = 162;
Review Comment:
I'll decide to place it in OMResponse. For a few reasons:
- Symmetry: #11449 put the flag on OMRequest. Keeping both the request flag
and response principal at the envelope level is consistent.
- Reusability: Other write-path PRs (PutObject, MPU) can reuse this field
directly without modifying individual response protos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
