szetszwo commented on PR #9472:
URL: https://github.com/apache/ozone/pull/9472#issuecomment-6297151678
@devmadhuu , some questions:
- It seems that the long description in the PR are mostly invalid. It
particular "storing a 2-byte health state" and all the "memory efficient"
calculations are invalid since the ContainerInfo is using the enum directly but
not a short. If yes, could you revise the description?
```java
// ContainerInfo
private ContainerHealthState healthState;
```
- Also, the ContainerInfo.value actually is unused -- it is only used in
tests. If yes, could we remove it?
- BTW, how the value is assigned?
- Define `ContainerHealthState.HEALTHY`. The description "Container is
healthy" does not explain what does it mean.
- UNDER_REPLICATED as an example, what are the difference between the cases
below?
1. UNDER_REPLICATED
2. UNHEALTHY_UNDER_REPLICATED
3. MISSING_UNDER_REPLICATED
4. QUASI_CLOSED_STUCK_UNDER_REPLICATED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
