ChenSammi commented on code in PR #11370:
URL: https://github.com/apache/ozone/pull/11370#discussion_r4311433506
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestScmClient.java:
##########
@@ -257,4 +266,72 @@ private DatanodeDetails randomDatanode() {
.build();
}
+ @Test
+ public void testDatanodeDetailsCacheUpdatesCurrentVersionChange() {
+ Cache<DatanodeID, DatanodeDetails> datanodeDetailsCache =
CacheBuilder.newBuilder().build();
+ DatanodeDetails original = randomDatanode();
+ original.setCurrentVersion(HDDSVersion.STREAM_BLOCK_SUPPORT);
+ DatanodeDetails upgraded = DatanodeDetails.newBuilder()
+ .setDatanodeDetails(original)
+ .setCurrentVersion(HDDSVersion.SHORT_CIRCUIT_READS)
+ .build();
+
+ ScmClient.newPipelineWithDNCache(createPipeline(1L,
asList(original)).getPipeline(), datanodeDetailsCache);
+ Pipeline refreshed = ScmClient.newPipelineWithDNCache(
+ createPipeline(2L, asList(upgraded)).getPipeline(),
datanodeDetailsCache);
+
+ assertSame(upgraded, refreshed.getNodes().get(0));
+ assertEquals(HDDSVersion.SHORT_CIRCUIT_READS,
refreshed.getNodes().get(0).getCurrentVersion());
+ assertSame(upgraded, datanodeDetailsCache.getIfPresent(original.getID()));
+ }
+
+ @Test
+ public void
testDatanodeDetailsCacheUpdatesKnownVersionToUnknownWireVersion() {
Review Comment:
@smengcl , thanks for the review.
There are three cases here,
1. update known version -> different known version
2. update known version -> unknown version
3. update one unknown version -> different unknown version
testDatanodeDetailsCacheUpdatesKnownVersionToUnknownWireVersion() is case 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
