andyhuangdev commented on PR #11528: URL: https://github.com/apache/ozone/pull/11528#issuecomment-6248548501
> Thanks for working on this, @andyhuangdev! > > I looked into it and noticed some expected shutdowns, like SCM decommission, also go through `shutDown()`. See the inline comments for details. Thanks for the review! Agreed on all four points. I’ll preserve exit status 0 for SCM decommission while keeping status 1 for fatal shutdowns, and add a decommission test in TestStorageContainerManagerHA that waits for the removed SCM to terminate and checks its exit status. I’ll also rename the test to testStateMachineCloseTerminatesWithFailureStatus and update the helper comment to say it waits for the state machine to be ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
