chihsuan commented on code in PR #11536: URL: https://github.com/apache/ozone/pull/11536#discussion_r4305963719
########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/__tests__/namespaceUsage/NUMetadata.test.tsx: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import React from 'react'; +import { cleanup, render, screen, waitFor, within } from '@testing-library/react'; +import { http, HttpResponse } from 'msw'; +import { setupServer } from 'msw/node'; + +import NUMetadata from '@/v2/components/nuMetadata/nuMetadata'; +import { showDataFetchError } from '@/utils/common'; + +vi.mock('@/utils/common', async () => ({ + ...await vi.importActual('@/utils/common'), + showDataFetchError: vi.fn() +})); + +const server = setupServer( Review Comment: nit: Would it be worth reusing the mocks in `namespaceUsageResponseMocks.ts` after merging master? They landed in #11513 after this branch was created, so probably easy to miss. The file already has `InitializingQuotaResponse` and other quota responses. ########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/components/nuMetadata/nuMetadata.tsx: ########## @@ -344,7 +350,7 @@ const NUMetadata: React.FC<MetadataProps> = ({ } // Error checks for quota response - if (quotaResponse.state === 'INITIALIZING') { + if (quotaResponse.status === 'INITIALIZING') { quotaResponsePresent = false; showDataFetchError(`The quota is currently initializing. Please wait a moment and try again later`); } Review Comment: As shown in your screenshot, this toast now fires next to the summary one. Users see two toasts for one initialization. Let's drop the `showDataFetchError` call here so users see only one toast, which may help avoid notification fatigue. ```suggestion if (quotaResponse.status === 'INITIALIZING') { quotaResponsePresent = false; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
