smengcl commented on code in PR #11571: URL: https://github.com/apache/ozone/pull/11571#discussion_r4301717138
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServer.java: ########## @@ -53,6 +53,12 @@ SCMRatisResponse submitRequest(SCMRatisRequest request) RaftServer.Division getDivision(); + /** + * Returns the maximum replication lag of SCM Ratis followers in Raft log entries. + * Returns 0 when this node is not the leader or non-HA (no throttling signal applies.) + */ + long getFollowerReplicationLag(); Review Comment: This new abstract method breaks the existing server-scm test stub: TestReplicationAnnotation still creates an anonymous SCMRatisServer without getFollowerReplicationLag(). The test sources therefore fail to compile because the anonymous class does not implement this method. Please add the stub override (return 0) or make the API method default before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
