devmadhuu commented on code in PR #11399:
URL: https://github.com/apache/ozone/pull/11399#discussion_r4280070281
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManagerUtil.java:
##########
@@ -120,6 +122,37 @@ public static List<DatanodeDetails>
getTargetDatanodes(PlacementPolicy policy,
SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
}
+ /** Selects targets using the storage type of each replica, including
containers with mixed replica types. */
+ public static Map<ContainerReplica, DatanodeDetails>
getTargetDatanodesForReplicas(PlacementPolicy policy,
+ Collection<ContainerReplica> replicas, List<DatanodeDetails> usedNodes,
List<DatanodeDetails> excludedNodes,
Review Comment:
This I am planning to handle in follow up PRs related to EC reconstruction
to keep this PR size in check,as there are few more EC reconstruction related
logic needs update.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -532,6 +550,7 @@ public void sendThrottledReplicationCommand(ContainerInfo
containerInfo,
ReplicateContainerCommand cmd =
ReplicateContainerCommand.toTarget(containerID, target);
cmd.setReplicaIndex(replicaIndex);
+ cmd.setTargetVolumeStorageType(targetVolumeStorageType);
Review Comment:
Thanks, this is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
