chihsuan commented on code in PR #11449:
URL: https://github.com/apache/ozone/pull/11449#discussion_r4240090981
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneManagerVersion.java:
##########
@@ -74,6 +74,9 @@ public enum OzoneManagerVersion implements ComponentVersion {
+ "client-side InfoBucket layout check for getFileChecksum"),
ZDU(100, "OzoneManager version that supports zero downtime upgrade"),
+ S3_MULTIPART_UPLOAD_ABORT_CONTEXT(101,
Review Comment:
Just a heads up, #11458 also adds 101, so whichever merges second will need
to bump. cc @rich7420
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -622,6 +622,11 @@ default OmMultipartUploadCompleteInfo
completeMultipartUpload(
"this to be implemented, as write requests use a new approach.");
}
+ /** Abort a multipart upload, optionally resolving its S3 volume on OM. */
+ default void abortMultipartUpload(OmKeyArgs omKeyArgs, boolean
assumeS3Context) throws IOException {
+ throw new UnsupportedOperationException("Write requests are handled
through OMClientRequest");
Review Comment:
nit: Should we reuse the message from the neighboring methods for
consistency?
```suggestion
throw new UnsupportedOperationException("OzoneManager does not require "
+
"this to be implemented, as write requests use a new approach.");
```
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/multitenant/TestMultiTenantVolume.java:
##########
@@ -186,6 +186,12 @@ public void testS3TenantVolume() throws Exception {
ObjectStore store2 = getStoreForAccessID(UUID.randomUUID().toString());
assertS3BucketNotFound(store2, BUCKET_NAME);
+ String keyName = "key";
+ String uploadID = bucket.initiateMultipartUpload(keyName).getUploadID();
+ store.getClientProxy().abortS3MultipartUpload(BUCKET_NAME, keyName,
uploadID);
Review Comment:
Could we also cover a link bucket in the tenant volume? The link may point
to another volume with a different layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
