chihsuan commented on code in PR #11459:
URL: https://github.com/apache/ozone/pull/11459#discussion_r4236228496
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
Review Comment:
I just found that this `endsWith(delimiter)` branch can't run. Filed
HDDS-16835 to clean it up.
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java:
##########
@@ -706,6 +706,26 @@ public void
listObjectOwnerIncludedForListV2WhenFetchOwnerTrue() throws OS3Excep
assertNotNull(response.getContents().get(0).getOwner());
}
+ @Test
+ public void delimiterScanKeepsLiteralPrefixes() throws Exception {
Review Comment:
This method seems to cover two independent scenarios, using `::` and `aa` as
delimiters. Could we move the aa case into its own test so failures are easier
to identify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
