rich7420 commented on code in PR #11430:
URL: https://github.com/apache/ozone/pull/11430#discussion_r4205372718


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3LifecycleConfiguration.java:
##########
@@ -181,6 +194,48 @@ public void setDaysAfterInitiation(Integer 
daysAfterInitiation) {
     }
   }
 
+  /**
+   * Transition entity for lifecycle rule. Ozone does not support lifecycle 
transition actions
+   * for any storage class; this is modeled only so a Transition element in 
the request is
+   * detected and rejected during conversion instead of being silently ignored.
+   */
+  @XmlAccessorType(XmlAccessType.FIELD)
+  @XmlRootElement(name = "Transition")
+  public static class Transition {
+    @XmlElement(name = "Days")

Review Comment:
   nit: Could we omit `Days` and `Date` and their accessors? Transition actions 
are always rejected, so only `StorageClass` is needed for the error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to