smengcl commented on code in PR #11348:
URL: https://github.com/apache/ozone/pull/11348#discussion_r4191765484
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneAtRestEncryption.java:
##########
@@ -672,6 +673,19 @@ private void testMultipartUploadWithEncryption(OzoneBucket
bucket,
try (OzoneInputStream inputStream = bucket.readKey(keyName)) {
assertInstanceOf(MultipartInputStream.class,
inputStream.getInputStream());
+ if (numParts == 2) {
+ inputStream.seek(123);
+ PositionedReadTestHelper.runConcurrentPositionedReads(inputData,
inputStream::readFully);
Review Comment:
Ditto. Could we extend testPutKeyWithEncryption with concurrent byte-array
and
ByteBuffer positioned reads, checking the returned plaintext and unchanged
sequential
position? Regular encrypted keys use Hadoop's CryptoInputStream directly,
which the
multipart coverage doesn't exercise.
Please use enough data to cross a crypto-buffer boundary and reuse the
existing
cluster/helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
