ss77892 commented on PR #11159: URL: https://github.com/apache/ozone/pull/11159#issuecomment-5941447122
> @ss77892 , thanks for working on this! The change looks good. Just has some minor suggestions to make the code easier to understand: > > * remove the preReadRefillThreshold field. > * change getPreReadRefillThreshold() to static > * add an `outstanding` local variable in readBlock(..) > > ``` @szetszwo Thank you for checking it. I've committed the changes. The failure in CI is actually not related and reveals a bug introduced by combination of HDDS-15521 and HDDS-16207. I will address it in a separate jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
