jojochuang commented on PR #11009: URL: https://github.com/apache/ozone/pull/11009#issuecomment-5914680079
I pushed a proposed follow-up fix to my fork: [6138bd8](https://github.com/jojochuang/ozone/commit/6138bd81d235b2124cb5cd0015f48cf37be39aa6) on [`HDDS-16164-dds-worker-submission-fix`](https://github.com/jojochuang/ozone/tree/HDDS-16164-dds-worker-submission-fix). The commit is based on the current PR head, `4428cf8`, and can be cherry-picked. The fix addresses the two outstanding worker-submission concerns: - Submit directly to the DDS executor rather than falling back to the common pool. A stopped executor now reaches the existing rejection handling, avoiding the barrier deadlock when the configured worker count exceeds common-pool parallelism. - Wait for the executor's completed-task count in the rejection test instead of assuming completion accounting has finished when the coordinator future returns. The rejection test now covers both partial rejection and an already-stopped executor with three configured workers. Validation on JDK 21: all 9 `TestDirectoryDeletingService` tests passed; both rejection cases also passed with `JAVA_TOOL_OPTIONS=-Djava.util.concurrent.ForkJoinPool.common.parallelism=2`; the repository checkstyle script and `git diff --check` passed. I did not rerun integration tests. Generated-by: Codex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
