anuragp010 commented on code in PR #11232:
URL: https://github.com/apache/ozone/pull/11232#discussion_r4132173862


##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/bucket/UpdateBucketHandler.java:
##########
@@ -35,6 +39,21 @@ public class UpdateBucketHandler extends BucketHandler {
       description = "Owner of the bucket to set")
   private String ownerName;
 
+  @Option(names = {"--storage-policy", "-s"},
+      description = "Bucket StoragePolicy. Allowed values: HOT, WARM, COLD, 
null "
+          + "(null clears the bucket's StoragePolicy). Leave unset to keep the 
"
+          + "current value.")
+  private String storagePolicyStr;
+
+  @Option(names = {"--allow-fallback-storage-policy", "-a"},
+      description = "When true, allocation may fall back to the 
StoragePolicy's "
+          + "fallback tier if the creation tier is unavailable. Leave unset to 
"
+          + "keep the current value.",
+      arity = "1")
+  private Boolean allowFallBackStoragePolicy;

Review Comment:
   Alright yes. To address the scenario where the 2 RPCs must remain atomic, I 
have updated the PR with option 2 and added tests for the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to