smengcl commented on PR #11146: URL: https://github.com/apache/ozone/pull/11146#issuecomment-5826139472
Follow-up to my comment above: the patch is pushed to this branch as `66bf80e1221`. @jojochuang, I went ahead rather than waiting for a reply, so say the word if you would rather have it as a separate PR and I will move it. Fixed: 1, 2, 3, 4, 5, 7, all of 8, and both assertions from the last section. - (1) and (2): wait for the node to reach `DEAD`, then for a three-replica set that excludes the stopped node. The replica set is settled before a node is picked, so `iterator().next()` can no longer throw. - (3): `restoreBadVolume` moved into a `finally`. The separate observation stands, it still only flips the file permission and does not clear the failed-volume list or recreate the pool. - (4): every wait in the decommission test now routes through one 30s helper, worst case around 210s. - (5): `client` is a field, closed in `@AfterAll` alongside the rest. - (7): both annotations removed. - (8): AssertJ throughout, the three config methods collapsed into one, the leftover no-op `getContainer(...)` calls dropped, single `UTF_8` import. - Last section: per-volume dispatch is now asserted. Each push compares `ThreadPoolExecutor.getCompletedTaskCount()` on the pool of the volume holding the container, and the decommission test waits for the pools to resize to `scaleOutOfServiceLimit(...)`. Both reachable from this package, so no production change. Not fixed: 6. `UniformDatanodesFactory.configureDatanodePorts` is shared test infrastructure and the fix changes behavior for every test using the factory, so it belongs in its own change. The `newCluster` wrapper stays for now. One caveat on the patch: I verified it with compile and `checkstyle:check` only and could not run the three tests locally, so CI is the first real execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
