F64116045 commented on code in PR #11293:
URL: https://github.com/apache/ozone/pull/11293#discussion_r4083708706
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1241,6 +1269,9 @@ message KeyInfo {
// This allows a key to be created an committed atomically if the original
has not
// been modified.
optional uint64 expectedDataGeneration = 22;
+ optional uint64 retentionDate = 23;
+ optional RetentionConfig retentionConfig = 24;
+ optional bool legalHold = 25 [default = false];
Review Comment:
Thanks @andyhuangdev for this patch.
Do Object Lock metadata changes need to be reported by Snapshot Diff? These
fields are currently skipped by
[computeKeyInfoCompareSignature()](https://github.com/apache/ozone/blob/a6e7a81699985e1b80d48aecd0c772edffcd148e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/diff/SnapshotDiffValueParser.java#L83-L133).
Not sure if we want to report it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
